Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot_policy modify, plus new options #59149

Merged
merged 1 commit into from Aug 9, 2019
Merged

snapshot_policy modify, plus new options #59149

merged 1 commit into from Aug 9, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Allow user to modify a snapshot policy
Add new options

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_snapshot_policy.py
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 16, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp storage support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jul 16, 2019
lonico
lonico reviewed Jul 16, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to hold on this PR until we submit the latest changes to netapp.py.
(One of the changes removes the sorting of lists, and this PR would fail if lists are sorted).

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 16, 2019
@carchi8py
Copy link
Contributor Author

This PR requires #59151 to be merged in first.

lonico
lonico approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 18, 2019
thedoubl3j
thedoubl3j approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new params covered, lgtm. shipit

@thedoubl3j thedoubl3j merged commit 48021a4 into ansible:devel Aug 9, 2019
@ansible ansible locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carchi8py @ansibot @lonico @thedoubl3j