Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt use sysprep only when needed #59196

Merged
merged 1 commit into from Jul 18, 2019
Merged

ovirt use sysprep only when needed #59196

merged 1 commit into from Jul 18, 2019

Conversation

mnecas
Copy link
Contributor

@mnecas mnecas commented Jul 17, 2019

SUMMARY

Check when user does pass empty dict to sysprep

Fixes oVirt/ovirt-ansible-vm-infra#104

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 17, 2019

cc @machacekondra @mwperina
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jul 17, 2019
@machacekondra
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jul 18, 2019
@ansibot ansibot merged commit 9489433 into ansible:devel Jul 18, 2019
mnecas added a commit to mnecas/ansible that referenced this pull request Jul 19, 2019
@mnecas
use sysprep only when needed (ansible#59196)
ea61d93
@mnecas mnecas mentioned this pull request Jul 19, 2019
Merged
abadger pushed a commit that referenced this pull request Jul 22, 2019
@mnecas @abadger
Ovirt correct sysprep backport (#59286)
5447dc8 
* use sysprep only when needed (#59196)

* add changelog
@ansible ansible locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Cannot use sysprep..." Error from playbook when using cloud-init only deployment
3 participants
@mnecas @ansibot @machacekondra