Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_firewall_rule - removed deprecated force option #59358

Merged
merged 1 commit into from
Jul 21, 2019
Merged

win_firewall_rule - removed deprecated force option #59358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/docsite/rst/porting_guides/porting_guide_2.9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ Noteworthy module changes
* The ``rds_snapshot_facts`` module was renamed to :ref:`rds_snapshot_info <rds_snapshot_info_module>`.
* The ``redshift_facts`` module was renamed to :ref:`redshift_info <redshift_info_module>`.
* The ``route53_facts`` module was renamed to :ref:`route53_info <route53_info_module>`.
* The deprecated ``force`` option in ``win_firewall_rule`` has been removed.


Plugins
Expand Down
5 changes: 0 additions & 5 deletions lib/ansible/modules/windows/win_firewall_rule.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ $security = Get-AnsibleParam -obj $params -name "security" -type "str" -validate

$state = Get-AnsibleParam -obj $params -name "state" -type "str" -default "present" -validateset "present","absent"

$force = Get-AnsibleParam -obj $params -name "force" -type "bool" -default $false
if ($force) {
Add-DeprecationWarning -obj $result -message "'force' isn't required anymore" -version 2.9
}

if ($diff_support) {
$result.diff = @{}
$result.diff.prepared = ""
Expand Down
7 changes: 0 additions & 7 deletions lib/ansible/modules/windows/win_firewall_rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,6 @@
- Defaults to C(domain,private,public) when creating a new rule.
type: list
aliases: [ profile ]
force:
description:
- Replace any existing rule by removing it first.
- This is no longer required in Ansible 2.4 as rules no longer need replacing when being modified.
- DEPRECATED in Ansible 2.4 and will be removed in Ansible 2.9.
type: bool
default: no
seealso:
- module: win_firewall
author:
Expand Down