Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module_utils.common.*: removed unused objects #59570

Merged
merged 2 commits into from
Jul 25, 2019
Merged

module_utils.common.*: removed unused objects #59570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc7a3e
module_utils.common.*: removed unused objects
Andersson007 Jul 25, 2019
edd8331
module_utils.common.*: removed unused objects, added changelog fragment
Andersson007 Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/59570-module_utils_remove_unused_objects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- module_utils - remove unused objects from dict_transformations, removed, and sys_info modules (https://github.com/ansible/ansible/pull/59570)
1 change: 0 additions & 1 deletion lib/ansible/module_utils/common/dict_transformations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ def _camel_to_snake(name, reversible=False):
def prepend_underscore_and_lower(m):
return '_' + m.group(0).lower()

import re
if reversible:
upper_pattern = r'[A-Z]'
else:
Expand Down
2 changes: 1 addition & 1 deletion lib/ansible/module_utils/common/removed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def removed_module(removed_in, msg='This module has been removed. The module doc
version = removed_in.split('.')
try:
numeric_minor = int(version[-1])
except Exception as e:
except Exception:
last_version = None
else:
version = version[:-1]
Expand Down
1 change: 0 additions & 1 deletion lib/ansible/module_utils/common/sys_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from __future__ import absolute_import, division, print_function
__metaclass__ = type

import os
import platform

from ansible.module_utils import distro
Expand Down