pbrun: Use default value for become_user #59754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require ternary operator for if get_option('user') returns NoneType object.
ansibot
added
affects_2.9
|
The testing failure marking needs_revision isn't the result of my change. |
ansibot
added
has_issue
community_review
bcoca
requested changes
Jul 30, 2019
bcoca
removed
the
needs_triage
Added default value to become_user in documentation.
Changed default for become_user to be '' instead of root.
bcoca
requested changes
Jul 30, 2019
bcoca
approved these changes
Jul 30, 2019
|
@nick6655 want to create a backport for 2.8? |
|
@bcoca I am ignorant to the process of creating a backport. Looking now to see if I can figure it out but not sure the ETA on that. |
|
a quick guide to backports |
nick6655
added a commit
to nick6655/ansible
that referenced
this pull request
Jul 31, 2019
* Update pbrun.py
Require ternary operator for if get_option('user') returns NoneType object.
* Update pbrun.py
Added default value to become_user in documentation.
* Update pbrun.py
Changed default for become_user to be '' instead of root.
(cherry picked from commit 1d560e5)
abadger
pushed a commit
that referenced
this pull request
Jul 31, 2019
* Update pbrun.py
Require ternary operator for if get_option('user') returns NoneType object.
* Update pbrun.py
Added default value to become_user in documentation.
* Update pbrun.py
Changed default for become_user to be '' instead of root.
(cherry picked from commit 1d560e5)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require ternary operator for if get_option('user') returns NoneType object.
SUMMARY
With all other become plugins user assignment is done with a ternary operator to default to '' if no user option is returned. This should be the same for pbrun become plugin.
ISSUE TYPE
COMPONENT NAME
pbrun
ADDITIONAL INFORMATION