Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource module for iosxr_l2_interfaces #59964

Merged
merged 12 commits into from Aug 27, 2019
Merged

Resource module for iosxr_l2_interfaces #59964

merged 12 commits into from Aug 27, 2019

Conversation

justjais
Copy link
Contributor

@justjais justjais commented Aug 2, 2019 •
edited

SUMMARY

Resource module for iosxr_l2_interfaces, with supported operations and respective integration tests. (ref model: iosxr_l2_interfaces model)

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

iosxr_l2_interfaces

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 2, 2019

cc @NilashishC @NilashishC @Qalthos @danielmellado @ganeshrn @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies ios Cisco IOS community iosxr Cisco IOSXR community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 2, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 2, 2019

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

lib/ansible/module_utils/network/iosxr/argspec/l2_interfaces/l2_interfaces.py:43:96: bad-whitespace Exactly one space required after comma                                                                               'choices': ['drop','forward', 'tunnel']},                                                                                                 ^
lib/ansible/module_utils/network/iosxr/argspec/l2_interfaces/l2_interfaces.py:45:96: bad-whitespace Exactly one space required after comma                                                                               'choices': ['drop','forward', 'tunnel']},                                                                                                 ^
lib/ansible/module_utils/network/iosxr/config/l2_interfaces/l2_interfaces.py:229:11: undefined-variable Undefined variable 'kwargs'
lib/ansible/module_utils/network/iosxr/config/l2_interfaces/l2_interfaces.py:230:25: undefined-variable Undefined variable 'kwargs'
lib/ansible/module_utils/network/iosxr/config/l2_interfaces/l2_interfaces.py:236:18: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/module_utils/network/iosxr/config/l2_interfaces/l2_interfaces.py:258:26: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/module_utils/network/iosxr/config/l2_interfaces/l2_interfaces.py:261:26: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:1518:0: undefined-label: undefined label: iosxr_l2_interface_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:1096:0: undefined-label: undefined label: iosxr_l2_interface_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:409:0: AttributeError: type object 'L2_Interfaces' has no attribute 'argument_spec'

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:409:0: AttributeError: type object 'L2_Interfaces' has no attribute 'argument_spec'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:409:0: AttributeError: type object 'L2_Interfaces' has no attribute 'argument_spec'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:409:0: AttributeError: type object 'L2_Interfaces' has no attribute 'argument_spec'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:409:0: AttributeError: type object 'L2_Interfaces' has no attribute 'argument_spec'

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/module_utils/network/iosxr/argspec/l2_interfaces/l2_interfaces.py:42:69: E231 missing whitespace after ':'
lib/ansible/module_utils/network/iosxr/argspec/l2_interfaces/l2_interfaces.py:43:97: E231 missing whitespace after ','
lib/ansible/module_utils/network/iosxr/argspec/l2_interfaces/l2_interfaces.py:45:79: E128 continuation line under-indented for visual indent
lib/ansible/module_utils/network/iosxr/argspec/l2_interfaces/l2_interfaces.py:45:97: E231 missing whitespace after ','
lib/ansible/modules/network/iosxr/iosxr_facts.py:91:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'iosxr_l2_interfaces'
lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'type object 'L2_Interfaces' has no attribute 'argument_spec''
lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:316:55: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_l2_interface.py:316:55: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 2, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

@justjais this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html test This PR relates to tests. labels Aug 7, 2019
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Aug 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 7, 2019

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/iosxr/config/l2_interfaces/l2_interfaces.py:141:26: SyntaxError: not_in_have = {()}

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/iosxr/config/l2_interfaces/l2_interfaces.py:141:26: SyntaxError: invalid syntax
lib/ansible/modules/network/iosxr/iosxr_l2_interfaces.py:402:0: SyntaxError: invalid syntax (l2_interfaces.py, line 141)

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/iosxr/iosxr_l2_interfaces.py:0:0: E325 Argument 'native_vlan' in argument_spec found in config defines type as 'int' but documentation defines type as 'str'
lib/ansible/modules/network/iosxr/iosxr_l2_interfaces.py:0:0: E337 Argument 'l2protocol' in argument_spec found in config defines type as 'list' but documentation doesn't define type
lib/ansible/modules/network/iosxr/iosxr_l2_interfaces.py:317:55: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_l2_interfaces.py:317:55: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 7, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Aug 7, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 7, 2019
@justjais justjais marked this pull request as ready for review August 7, 2019 17:30
@justjais justjais changed the title [WIP]Resource module for iosxr_l2_interfaces Resource module for iosxr_l2_interfaces Aug 7, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 26, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 26, 2019
@justjais
fix doc
bb6a778 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
fix doc
da905c0 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansible-zuul
Copy link

ansible-zuul bot commented Aug 26, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 26, 2019

Build succeeded (third-party-check pipeline).

danielmellado
danielmellado approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Sumit!

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 27, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@justjais
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 27, 2019

Build succeeded (third-party-check pipeline).

@justjais justjais merged commit b53bc94 into ansible:devel Aug 27, 2019
@ikhan2010 ikhan2010 moved this from Module in Review to Module Completed in Ansible 2.9 Networking Feature Dev Aug 27, 2019
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@justjais @adharshsrivatsr
Resource module for iosxr_l2_interfaces (ansible#59964)
a31291c 
* iosxr_l2 resource
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@justjais @anas-shami
Resource module for iosxr_l2_interfaces (ansible#59964)
dd0401e 
* iosxr_l2 resource
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
@justjais justjais deleted the iosxr_l2_interface branch October 18, 2019 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielmellado danielmellado danielmellado approved these changes

@NilashishC NilashishC NilashishC approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

@Qalthos Qalthos Awaiting requested review from Qalthos

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

@rohitthakur2590 rohitthakur2590 Awaiting requested review from rohitthakur2590

@cidrblock cidrblock Awaiting requested review from cidrblock

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community iosxr Cisco IOSXR community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
Ansible 2.9 Networking Feature Dev
  
Module Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @ansibot @NilashishC @danielmellado