Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIGIP: fixes issue with receive parameter idempotency #59999

Merged
merged 1 commit into from
Aug 2, 2019
Merged

BIGIP: fixes issue with receive parameter idempotency #59999

merged 1 commit into from
Aug 2, 2019

Conversation

wojtek0806
Copy link
Contributor

SUMMARY

fixes assert statements in unit test
fixes issue with receive parameter idempotency

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/f5/bigip_monitor_http.py
lib/ansible/modules/network/f5/bigip_monitor_https.py
test/units/modules/network/f5/test_bigip_device_connectivity.py
test/units/modules/network/f5/test_bigip_gtm_wide_ip.py
test/units/modules/network/f5/test_bigip_monitor_http.py
test/units/modules/network/f5/test_bigip_monitor_https.py

ADDITIONAL INFORMATION

@wojtek0806
fixes issue with recieve parameter idempotency
c7e6822 
fixes assert statements in unit tests
@ansibot
Copy link
Contributor

ansibot commented Aug 2, 2019

cc @caphrim007
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 2, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 2, 2019

cc @caphrim007
click here for bot help

@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Aug 2, 2019
@caphrim007
Copy link
Contributor

shipit

@caphrim007 caphrim007 merged commit c9a9621 into ansible:devel Aug 2, 2019
samdoran pushed a commit to samdoran/ansible that referenced this pull request Aug 13, 2019
@wojtek0806 @samdoran
[stable-2.8] fixes issue with recieve parameter idempotency (ansible#…
e2c1d7f 
…59999)

fixes assert statements in unit tests
(cherry picked from commit c9a9621)

Co-authored-by: Wojciech Wypior <w.wypior@f5.com>
@samdoran samdoran mentioned this pull request Aug 13, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@caphrim007 caphrim007 caphrim007 approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category small_patch support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wojtek0806 @ansibot @caphrim007