VMware: refactor REST APIs

[Akasurde]

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

lib/ansible/module_utils/vmware_rest_client.py
lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py
lib/ansible/modules/cloud/vmware/vmware_host_facts.py
lib/ansible/modules/cloud/vmware/vmware_vm_facts.py

[Akasurde]

cc @Tomorrow9 @pgbidkar

[ansibot]

cc @goneri @lparkes @sumkincpp @warthog9 @woshihaoren
click here for bot help

[ansibot]

cc @goneri @lparkes @sumkincpp @warthog9 @woshihaoren
click here for bot help

[jillr]

Overall this change looks pretty good but I wonder if we could remove some of the boilerplate by changing to a general purpose get_tags type of method that takes an argument of the DynamicID type, then module writers could create new tag lookups on the fly without having to add to vmware_rest_client.py. Do you think something like this would work in practice? (Not sure if the method name here makes the most sense, but just as an example).

    def get_tags_for_dynamic_obj(self, mid=None, type=None):
        """
        Return list of tag object associated with object
        Args:
            mid: Dynamic object for specified object
            type: Type of DynamicID to lookup

        Returns: List of tag object associated with the given host system

        """
        tags = []
        if mid is None:
            return tags
        dynamic_managed_object = DynamicID(type=type, id=mid)

        temp_tags_model = self.get_tags_for_object(dynamic_managed_object)

        category_service = self.api_client.tagging.Category

        for tag_obj in temp_tags_model:
            tags.append({
                'id': tag_obj.id,
                'category_name': category_service.get(tag_obj.category_id).name,
                'name': tag_obj.name,
                'description': tag_obj.description,
                'category_id': tag_obj.category_id,
            })

        return tags```