proxmox: support version 6

[morph027]

SUMMARY

Proxmox VE Version 6 Release slightly changed it's API regarding the version string (original issue: swayf/proxmoxer#79). This fix picks up the new version scheme and still supports the old one.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

proxmox

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:0: syntax-error invalid syntax (<unknown>, line 485)

The test ansible-test sanity --test ansible-doc [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:0:0: missing documentation (or could not parse documentation): invalid syntax (<unknown>, line 485)

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:98: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 698, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 225, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 485
    global PVE_VERSION = float(re.sub(r'-\d$', '', proxmox.version.get()['version']))
                       ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: global PVE_VERSION = float(re.sub(r'-\d$', '', proxmox.version.get()['version']))

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: global PVE_VERSION = float(re.sub(r'-\d$', '', proxmox.version.get()['version']))

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: global PVE_VERSION = float(re.sub(r'-\d$', '', proxmox.version.get()['version']))

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: global PVE_VERSION = float(re.sub(r'-\d$', '', proxmox.version.get()['version']))

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: global PVE_VERSION = float(re.sub(r'-\d$', '', proxmox.version.get()['version']))

The test ansible-test sanity --test compile --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: global PVE_VERSION = float(re.sub(r'-\d$', '', proxmox.version.get()['version']))

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: SyntaxError: invalid syntax

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/misc/proxmox.py:0:0: E401 Python SyntaxError while parsing module
test/sanity/ignore.txt:1573:1: A100 Ignoring 'E337' on 'lib/ansible/modules/cloud/misc/proxmox.py' is unnecessary
test/sanity/ignore.txt:1574:1: A100 Ignoring 'E338' on 'lib/ansible/modules/cloud/misc/proxmox.py' is unnecessary

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/proxmox.py:485:28: python-syntax-error invalid syntax (<unknown>, line 485)

click here for bot help

[ansibot]

cc @UnderGreen @joshainglis @karmab
click here for bot help

[pvanhemmen]

This required fix works as expected and makes the proxmoxer module compatible with the actual Proxmox 6.x stable release.

[J4RF]

Is this ever going to be merged?

[morph027]

Huh, guess i should do some rebasing ...

[morph027]

hm, by looking at current devel, it looks like @mrdrogdrog fixed this in 38193f6 already....