New options to Interface #60499
Merged
New options to Interface #60499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
|
@thedoubl3j how do we force ansibot to return this? |
|
The test |
thedoubl3j
reviewed
Aug 20, 2019
lonico
reviewed
Aug 20, 2019
| if parameters.get('dns_domain_name') is not None: | ||
| options['dns-domain-name'] = parameters['dns_domain_name'] | ||
| if parameters.get('listen_for_dns_query') is not None: | ||
| options['listen-for-dns-query'] = str(parameters['listen_for_dns_query']) |
There was a problem hiding this comment.
Is it enough to use str, or do we need to convert to lowercase?
Look also at line 296. Should we use the same construct?
There was a problem hiding this comment.
I confirmed the ZAPI accepts both False and false, or True and true, so this is OK as is.
It's only when making comparisons with returned values (get), that we need to be case sensitive.
lonico
suggested changes
Aug 20, 2019
| @@ -237,6 +263,14 @@ def get_interface(self): | |||
| return_value['netmask'] = interface_attributes['netmask'] | |||
| if interface_attributes.get_child_by_name('firewall-policy'): | |||
| return_value['firewall_policy'] = interface_attributes['firewall-policy'] | |||
| if interface_attributes.get_child_by_name('dns-domain-name') is not 'none': | |||
There was a problem hiding this comment.
should be != 'none'
is not None is correct. is not 'none' is not correct.
ansibot
removed
the
needs_triage
|
@carchi8py @lonico still waiting on fixes for this one |
ansibot
removed
the
ci_verified
ansibot
added
shipit
thedoubl3j
approved these changes
Aug 28, 2019
adharshsrivatsr
pushed a commit
to adharshsrivatsr/ansible
that referenced
this pull request
Sep 3, 2019
* update to interface * force ansibot to run again * fixes
anas-shami
pushed a commit
to anas-shami/ansible
that referenced
this pull request
Sep 23, 2019
* update to interface * force ansibot to run again * fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
New Options for Interface
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION