Update ansible-test --windows inventory creation. #60911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host specific settings are created as part of the generated inventory instead of using a host_vars directory. Also update connection tests to work properly with the generated inventory changes. ci_complete
ansibot
added
affects_2.9
mattclay
removed
the
needs_triage
ansibot
added
needs_revision
jborean93
requested changes
Aug 20, 2019
| ansible -i ../../inventory.winrm localhost \ | ||
| -m template \ | ||
| -a "src=test_connection.inventory.j2 dest=${OUTPUT_DIR}/test_connection.inventory" \ | ||
| -e "test_shell_type=cmd" \ |
There was a problem hiding this comment.
This is only needed for ssh, has no affect for winrm and psrp.
| ansible -i ../../inventory.winrm localhost \ | ||
| -m template \ | ||
| -a "src=test_connection.inventory.j2 dest=${OUTPUT_DIR}/test_connection.inventory" \ | ||
| -e "test_shell_type=cmd" \ |
There was a problem hiding this comment.
Same here, this isn't needed.
jborean93
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update ansible-test --windows inventory creation.
Host specific settings are created as part of the generated inventory instead of using a host_vars directory.
Also update connection tests to work properly with the generated inventory changes.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ansible-test