Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behaviour of module_utils/ec2 compare_policies when dealing with bare bools and ints. #61115

Merged
merged 3 commits into from Sep 9, 2019
Merged

Fix behaviour of module_utils/ec2 compare_policies when dealing with bare bools and ints. #61115

merged 3 commits into from Sep 9, 2019

Commits on Sep 6, 2019

  1. module_utils/ec2: (unit tests) Move unit tests for module_utils/ec2.p… 

    …y into test/units/module_utils

- compare_policies was refactored from s3_bucket
- "ec2_utils" doesn't seem to have ever existed
    @tremble
    tremble committed Sep 6, 2019
    Copy the full SHA
    c2c44b2 View commit details
    Browse the repository at this point in the history

  2. module_utils/ec2: (unit tests) Add unit test for comparing quoted and… 

    … unquoted bools and numbers within policies

As per https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html

"Values are enclosed in quotation marks. Quotation marks are optional for numeric
and Boolean values."
    @tremble
    tremble committed Sep 6, 2019
    Copy the full SHA
    8718b27 View commit details
    Browse the repository at this point in the history

  3. module_utils/ec2: Explicitly convert bools and ints to strings when c… 

    …omparing policies

See also: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html
    @tremble
    tremble committed Sep 6, 2019
    Copy the full SHA
    34d88d0 View commit details
    Browse the repository at this point in the history