New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mysql_db.py, adding encoding to enforce charset for import #61216
Conversation
`encoding` is used for creation of database, but not for import of sql scripts. The import fails to import `latin1` encoded sql script, cause it consider it's by default some utf8 This commit add `--default-character-set=encoding` when the import function is called with an encoding argument. This way this option is added to the mysql command line, and import is successfull.
The test
|
Fix the linter issue and add another control to test encoding var.
Fix again lint error ! :)
Hi, two things:
Could you please reopen this against devel? |
Hello @abadger i understand your point. If you can have a look at the PR on devel branch i submitted, would be nice too :) |
SUMMARY
encoding
is used for creation of database, but not for import of sql scripts.The import fails to import
latin1
encoded sql script, cause it consider it's by default some utf8This commit add
--default-character-set=encoding
when the import function is called with an encoding argument.This way this option is added to the mysql command line, and import is successfull.
ISSUE TYPE
COMPONENT NAME
mysql_db
ADDITIONAL INFORMATION