Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local plays to execute when --ask-sudo-pass is used on the command line #613

Merged
merged 3 commits into from
Jul 18, 2012
Merged

Allow local plays to execute when --ask-sudo-pass is used on the command line #613

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4303c8
Avoid spurious error when mixing a local play with remote plays depen…
Jul 18, 2012
0d53b1b
Change previous fix to a one line change relative to upstream
Jul 18, 2012
26dc607
Revert "Change previous fix to a one line change relative to upstream"
Jul 18, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/ansible/runner/connection/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ def exec_command(self, cmd, tmp_path, sudo_user, sudoable=False):
''' run a command on the local host '''

if self.runner.sudo and sudoable:
if self.runner.sudo_pass:
# NOTE: if someone wants to add sudo w/ password to the local connection type, they are welcome
# to do so. The primary usage of the local connection is for crontab and kickstart usage however
# so this doesn't seem to be a huge priority
raise errors.AnsibleError("sudo with password is presently only supported on the paramiko (SSH) connection type")
cmd = "sudo -s %s" % cmd
if self.runner.sudo_pass:
# NOTE: if someone wants to add sudo w/ password to the local connection type, they are welcome
# to do so. The primary usage of the local connection is for crontab and kickstart usage however
# so this doesn't seem to be a huge priority
raise errors.AnsibleError("sudo with password is presently only supported on the paramiko (SSH) connection type")

p = subprocess.Popen(cmd, shell=True, stdin=None,
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
Expand Down