Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure postgresql tests are run for all postgres_* modules #61647

Merged
merged 1 commit into from Aug 31, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Right now, most modules are not listed in test/integration/targets/postgresql/aliases.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/integration/targets/postgresql/aliases

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Aug 31, 2019
@Andersson007
Copy link
Contributor

@felixfontein thanks! Would be cool to see it merged asap! I will remember to add new modules to this file, thank you

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 31, 2019
@felixfontein
Copy link
Contributor Author

I interpret that as a shipit :)

@felixfontein felixfontein merged commit 4d057e0 into ansible:devel Aug 31, 2019
@felixfontein felixfontein deleted the postgres-tests branch August 31, 2019 16:12
@felixfontein
Copy link
Contributor Author

Can you create backports to stable-2.9 and stable-2.8 (that probably needs a few less names in aliases)?

@Andersson007
Copy link
Contributor

@felixfontein , sure, I’ll do it on Monday

Andersson007 pushed a commit to Andersson007/ansible that referenced this pull request Sep 2, 2019
Andersson007 pushed a commit to Andersson007/ansible that referenced this pull request Sep 2, 2019
Andersson007 added a commit to Andersson007/ansible that referenced this pull request Sep 2, 2019
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
abadger pushed a commit that referenced this pull request Sep 3, 2019
abadger pushed a commit that referenced this pull request Sep 4, 2019
* Make sure postgresql tests are run for all postgres_* modules (#61647)

(cherry picked from commit 4d057e0)

* Make sure postgresql tests are run for all postgres_* modules (#61647), remove non-existent
@mattclay
Copy link
Member

mattclay commented Sep 9, 2019

@felixfontein Is there a reason for most of these modules to be tested using a single test target instead of having a dedicated target for each?

@felixfontein
Copy link
Contributor Author

@mattclay I don't know, better ask that @Andersson007. I just wanted to make sure that the tests are actually triggered when a module which is tested by them is changed.

@Andersson007
Copy link
Contributor

hello @mattclay and @felixfontein , i think there are some reasons for doing this using a single target because it was made in this way seems a long time ago and now some tests probably depend on the other.
It could be painful to split them but on the other hand i agree it would be, at least, much faster and convenient to work with split tests.
@mattclay If you asked becouse you'd like to do it, ok, welcome :) if it is a suggestion - thank you for the idea, i should try to split them :) it would be really cool. I should look at this in detail and evaluate how painful it might be :)

@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants