YAML parser - set source file position for vault encrypted strings #61660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
|
Please add tests as well as a changelog fragment. See this fragment as an example. |
samdoran
removed
the
needs_triage
ansibot
added
core_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The PR adds the source position to vault encrypted string objects read by the YAML parser, just like it is done for other YAML types (strings, sequences, mappings).
This rather small change will allow third-party script to query the source location of a specific variable by using
VariableManagerand similar techniques.ISSUE TYPE
COMPONENT NAME
YAML Parser hotfix.
ADDITIONAL INFORMATION
Third-party scripts can query the source location of variables read by VariableManager by using the ansible_pos attribute of variables. However, this attribute is not set for vault encrypted strings while it is for the other YAML types. This PR will simply add the attribute for this kind of objects as well.