Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yandex.Cloud inventory plugin #61722

Closed
wants to merge 13 commits into from
Closed

Yandex.Cloud inventory plugin #61722

wants to merge 13 commits into from

Conversation

st8f
Copy link

@st8f st8f commented Sep 3, 2019

SUMMARY

Yandex.Cloud inventory plugin

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

yc_compute

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 3, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2019

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/plugins/inventory/yc_compute.py:194:45: ansible-format-automatic-specification: Format string contains automatic field numbering specification
lib/ansible/plugins/inventory/yc_compute.py:249:39: ansible-format-automatic-specification: Format string contains automatic field numbering specification
lib/ansible/plugins/inventory/yc_compute.py:254:35: ansible-format-automatic-specification: Format string contains automatic field numbering specification
lib/ansible/plugins/inventory/yc_compute.py:263:31: ansible-format-automatic-specification: Format string contains automatic field numbering specification

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/plugins/inventory/yc_compute.py:10:61: W291: trailing whitespace
lib/ansible/plugins/inventory/yc_compute.py:36:70: W291: trailing whitespace
lib/ansible/plugins/inventory/yc_compute.py:42:116: W291: trailing whitespace

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/plugins/inventory/yc_compute.py:0:0: file without shebang should not be executable

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 3, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 3, 2019
@st8f st8f requested a review from s-hertel September 9, 2019 16:38
@st8f
Copy link
Author

st8f commented Sep 16, 2019

@s-hertel Hi! Is everything ok with this PR? Should I add more ansible members?

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. botmeta This PR modifies the BOTMETA.yml and this requires special attention! core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 16, 2019
@st8f
Copy link
Author

st8f commented Sep 19, 2019

ready_for_review

@samdoran samdoran added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_triage Needs a first human triage before being processed. labels Sep 19, 2019
Vladimir Stefanovskiy and others added 12 commits January 17, 2020 21:11
Bump 'version_added' to 2.10
bfeb6f4
Fix sanity
eb6e371
Use 'groups' option from base class instead of custom 'conditional_gr…
62993fd 
…oups'
Add maintainers for yc_compute.py
589c790
@st8f @samdoran
Sort imports
00a1562 
Co-Authored-By: Sam Doran <sdoran@redhat.com>
@st8f @samdoran
Sort imports
82ae312 
Co-Authored-By: Sam Doran <sdoran@redhat.com>
Fix style
5e8f297
@st8f @s-hertel
Fix typo
1b13ff9 
Co-Authored-By: Sloane Hertel <shertel@redhat.com>
@st8f @s-hertel
Fix typo
3c6ae5b 
Co-Authored-By: Sloane Hertel <shertel@redhat.com>
@st8f @s-hertel
Fix import
868ff81 
Co-Authored-By: Sloane Hertel <shertel@redhat.com>
@st8f @s-hertel
Fix import
d0ec060 
Co-Authored-By: Sloane Hertel <shertel@redhat.com>
Remove no_log entries from doc
324dac4
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 17, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 25, 2020
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 2, 2020
@Akasurde
Copy link
Member

Akasurde commented Jul 2, 2020

@st8f Thank you very much for your interest in Ansible. This plugin/module is no longer maintained in this repository and has been migrated to community.general. Could you please migrate this PR to the above-mentioned repo?

If you have further questions please stop by IRC or the mailing list:

Thanks,

needs_info

@ansibot ansibot added the needs_info This issue requires further information. Please answer any outstanding questions. label Jul 2, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 3, 2020

@st8f This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@st8f st8f mentioned this pull request Aug 13, 2020
Closed
@st8f st8f closed this Aug 13, 2020
@st8f
Copy link
Author

st8f commented Aug 13, 2020

Moved to ansible-collections/community.general#772

@st8f st8f deleted the yc branch August 13, 2020 14:51
@ansible ansible locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran left review comments

@s-hertel s-hertel s-hertel left review comments

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 botmeta This PR modifies the BOTMETA.yml and this requires special attention! feature This issue/PR relates to a feature request. needs_info This issue requires further information. Please answer any outstanding questions. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@st8f @ansibot @Akasurde @samdoran @s-hertel