Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_l3_interfaces: Exclude mgmt0 *Fixes testbed breakage* #61788

Closed
wants to merge 5 commits into from
Closed

nxos_l3_interfaces: Exclude mgmt0 *Fixes testbed breakage* #61788

wants to merge 5 commits into from

Commits on Sep 4, 2019

  1. nxos_l3_interfaces: Exclude mgmt0 *Fixes testbed breakage* 

    - This fix excludes `mgmt0` from the list of manageable interfaces. See new method `sanitize_interface_facts`.
- Users should not modify mgmt0 settings with this module; if necessary they can use the nxos_config module.
- The current code includes an `overridden` integration test that results in removing the ip address from `mgmt0`, which breaks the test along with subsequent tests.
- I also included a simple unit test that verifies basic functionality and checks for `mgmt0` usage. This test should be expanded upon with more detailed tests at some point.
    @chrisvanheuveln
    chrisvanheuveln committed Sep 4, 2019
    Copy the full SHA
    e2391e8 View commit details
    Browse the repository at this point in the history

  2. lint 1

    @chrisvanheuveln
    chrisvanheuveln committed Sep 4, 2019
    Copy the full SHA
    b218969 View commit details
    Browse the repository at this point in the history

  3. remove dead code

    @chrisvanheuveln
    chrisvanheuveln committed Sep 4, 2019
    Copy the full SHA
    fe9df22 View commit details
    Browse the repository at this point in the history

  4. lint 2

    @chrisvanheuveln
    chrisvanheuveln committed Sep 4, 2019
    Copy the full SHA
    6ed6e3f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. method rename s/sanitize_interface_facts/remove_rsvd_interfaces/

    @chrisvanheuveln
    chrisvanheuveln committed Sep 6, 2019
    Copy the full SHA
    c764b64 View commit details
    Browse the repository at this point in the history