Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.9: Handle cases where normal commit operation throws a prompt (#62132) #62191

Merged
merged 1 commit into from Sep 17, 2019
Merged

Backport 2.9: Handle cases where normal commit operation throws a prompt (#62132) #62191

merged 1 commit into from Sep 17, 2019

Conversation

NilashishC
Copy link
Contributor

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com
(cherry picked from commit f176645)

Add changelog for iosxr prompt fix

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cliconf/iosxr.py

@ansibot
Copy link
Contributor

ansibot commented Sep 12, 2019

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/62131-iosxr_prompt_fix.yaml:0:0: invalid section: bug_fixes

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 12, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cisco Cisco technologies iosxr Cisco IOSXR community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 12, 2019
@NilashishC
Handle cases where normal commit operation throws a prompt (ansible#6…
e6224a3 
…2132)

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit f176645)

Add changelog for iosxr prompt fix
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 12, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 12, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@NilashishC
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Sep 12, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@NilashishC
Copy link
Contributor Author

@pabelanger we're repeatedly seeing connection issues in this PR's tests. Basically, the Socket is closed and the related issues I believe.

@NilashishC
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Sep 13, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@pabelanger
Copy link
Contributor

recheck

@pabelanger
Copy link
Contributor

We have made iosxr jobs non-voting now, until we have a new version of the appliance online. This means, status check will pass, if iosxr fails. But we should still manually check results to confirm new issue isn't exposed.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 13, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 13, 2019

Build succeeded (third-party-check pipeline).

abadger
abadger reviewed Sep 17, 2019
View reviewed changes
lib/ansible/plugins/cliconf/iosxr.py
# throws a prompt and we need to handle it before
# proceeding further
cmd_obj['prompt'] = '(C|c)onfirm'
cmd_obj['answer'] = 'y'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API is odd... it seems to be, if I encounter this prompt, give it the answer. But it doesn't require the prompt to occur. Since that's what is desired here, there's no bug and I'll merge it.... Just commenting because that's not the standard way to write an API and it took me a bit to analyze the code to be sure that it was actually doing this.

@abadger abadger merged commit 3765a08 into ansible:stable-2.9 Sep 17, 2019
@abadger
Copy link
Contributor

abadger commented Sep 17, 2019

Merged for the 2.9.0rc1 release.

@ansible ansible locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. iosxr Cisco IOSXR community networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NilashishC @ansibot @pabelanger @abadger