Added modules to manage ec2 autoscaling groups #6233
Conversation
Includes management of Launch Configuration and related Autoscaling Groups
|
Excellent, glad to see this. We're going to do a push to merge a LOT of the cloud stuff in a little over 1-2 weeks. This will be a great addition. |
|
Excellent. Any feedback/changes/etc. just let me know |
| - register or deregister the instance | ||
| required: true | ||
| choices: ['present', 'absent'] | ||
| group: |
There was a problem hiding this comment.
group does not match group_name on line 78, and does not match name on line 111 and 137.
My preference is to change all of them to simple name.
There was a problem hiding this comment.
Thanks, I've corrected the documentation and the example. I agree, name provides a better interface.
I've left the internal variable name as group_name however as that maps to the actual AWS name. Making this more explicit if you're in the code feels useful to me.
|
I would like to see this support 2 more things
Otherwise, great work. |
| print "failed=True msg='boto required for this module'" | ||
| sys.exit(1) | ||
|
|
||
| AWS_REGIONS = ['ap-northeast-1', |
There was a problem hiding this comment.
No need to define AWS_REGIONS in modules that include module_utils/ec2.py
|
Would be good to handle existing launchconfigurations in the create_autoscaling_groups (same as how you check that it exists before you delete it) rather than catch it in the same exception that will handle connection/authentication failures. The more information a module returns, the better, in general. |
|
Yes!! Love to see this merged! |
Added modules to manage ec2 autoscaling groups
|
Merged, thank you! We would be also welcome to entertain future upgrades if folks have suggestions/additions. |
|
Further improvements in #6419. |
ansibot
added
feature
Includes management of Launch Configuration and related Autoscaling
Groups.
Based on a complete working example here: https://github.com/garethr/ansible-provisioner-aws