Account for empty strings when splitting the host pattern #62442
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivel
approved these changes
Sep 17, 2019
ansibot
added
affects_2.10
bcoca
reviewed
Sep 17, 2019
bcoca
requested changes
Sep 17, 2019
- add more unit test cases - add specific integration test with more cases
bcoca
reviewed
Sep 18, 2019
|
The test |
Testing shows no major downside to calling .strip() twice in a comprehnios vs. using a regular for loop and only calling .strip() once. Going with the comprehension for ease of maintenance and because comprehensions are optimized in CPython.
samdoran
force-pushed
the
issue/61964-limit-comma-split
branch
from
75cca92
to
37bbf1a
Compare
samdoran
removed
the
needs_triage
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Sep 20, 2019
ansible#62442) Improve tests - add more unit test cases - add specific integration test with more cases Testing shows no major downside to calling .strip() twice in a comprehension vs. using a regular for loop and only calling .strip() once. Going with the comprehension for ease of maintenance and because comprehensions are optimized in CPython. (cherry picked from commit 987265a) Co-authored-by: Sam Doran <sdoran@redhat.com>
anas-shami
pushed a commit
to anas-shami/ansible
that referenced
this pull request
Sep 23, 2019
) Improve tests - add more unit test cases - add specific integration test with more cases Testing shows no major downside to calling .strip() twice in a comprehension vs. using a regular for loop and only calling .strip() once. Going with the comprehension for ease of maintenance and because comprehensions are optimized in CPython.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Filter out empty strings when returning the list of hosts from
split_host_pattern().Fixes #61964
ISSUE TYPE
COMPONENT NAME
lib/ansible/inventory/manager.py