Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session_uid traceback error when tested with newly introduced resource modules #62523

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Session_uid traceback error when tested with newly introduced resource modules #62523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/ansible/module_utils/network/checkpoint/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def api_call(module, api_call_object):
payload = get_payload_from_parameters(module.params)
connection = Connection(module._socket_path)

result = {'changed': False, 'checkpoint_session_uid': connection.get_session_uid()}
result = {'changed': False}
if module.check_mode:
return result

Expand All @@ -196,6 +196,8 @@ def api_call(module, api_call_object):
payload_for_equals = {'type': api_call_object, 'params': payload}
equals_code, equals_response = send_request(connection, version, 'equals', payload_for_equals)

result['checkpoint_session_uid'] = connection.get_session_uid()

# if code is 400 (bad request) or 500 (internal error) - fail
if equals_code == 400 or equals_code == 500:
module.fail_json(msg=equals_response)
Expand Down Expand Up @@ -343,7 +345,7 @@ def api_call_for_rule(module, api_call_object):
payload = get_payload_from_parameters(module.params)
connection = Connection(module._socket_path)

result = {'changed': False, 'checkpoint_session_uid': connection.get_session_uid()}
result = {'changed': False}
if module.check_mode:
return result

Expand All @@ -356,6 +358,9 @@ def api_call_for_rule(module, api_call_object):
copy_payload_without_some_params = get_copy_payload_without_some_params(payload, ['position'])
payload_for_equals = {'type': api_call_object, 'params': copy_payload_without_some_params}
equals_code, equals_response = send_request(connection, version, 'equals', payload_for_equals)

result['checkpoint_session_uid'] = connection.get_session_uid()

# if code is 400 (bad request) or 500 (internal error) - fail
if equals_code == 400 or equals_code == 500:
module.fail_json(msg=equals_response)
Expand Down