Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

really clarify environment #62531

Merged
merged 2 commits into from
Nov 11, 2019
Merged

really clarify environment #62531

merged 2 commits into from
Nov 11, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Sep 18, 2019

People keep assuming some plugins will be affected inline, hopefully this dispels that

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

keywords

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 18, 2019
@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 19, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 19, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 1, 2019
@samccann @gundalow
Apply suggestions from code review
6206ff4 
Co-Authored-By: John R Barker <john@johnrbarker.com>
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 11, 2019
@samccann samccann merged commit c1493e5 into ansible:devel Nov 11, 2019
@ansible ansible locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. pr_day Has been reviewed during a PR review Day small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @ansibot @gundalow @samccann