hcloud_volume: clarify volume size units #62771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [API documentation](https://docs.hetzner.cloud/#volumes) the volume size is given and returned in GB. Mention the size in the input parameter and fix the unit in the return parameter.
ansibot
added
affects_2.10
ansibot
removed
the
needs_triage
samccann
approved these changes
Sep 24, 2019
|
Thanks @liff for the Ansible documentation fix! |
samccann
pushed a commit
to samccann/ansible
that referenced
this pull request
Sep 24, 2019
(cherry picked from commit 190b8fc)
Merged
acozine
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Update pip module docs (#62359) * Clarifying pip module requirements in reference to #47361 * Further clarifying message with link to ansible_python_interpreter (cherry picked from commit d3ec5ca) * chore/doc-module: sts_assume_role.py (#62475) Update `Example` section with with the correct module usage. (cherry picked from commit a4a2166) * Improve dconf documentation to include conversion problems (#62316) (cherry picked from commit 8649283) * Add examples for various inventory setups to the documentation (#62323) * Updates docs/docsite/rst/user_guide/intro_inventory.rst, closes #12480. * Use code-block and rename groups in inventory setup examples * Fix group name in inventory setup example Co-Authored-By: Sandra McCann <samccann@redhat.com> (cherry picked from commit 7047b66) * added networking porting guide info (#61999) * Update docs/docsite/rst/porting_guides/porting_guide_2.9.rst Co-Authored-By: Nathaniel Case <this.is@nathanielca.se> (cherry picked from commit 6d35f90) * [docs] split collections into user and dev guide sections (#62363) (cherry picked from commit 7badeb6) * fixed options (#62605) (cherry picked from commit 170b4e6) * ec2_vpc_subnet: Rename resource_tags > tags (#62663) Most of the AWS module documentation refers to `tags` and not `resource_tags`. This patch updates the documentation to match other AWS module documentation. 😉 Signed-off-by: Major Hayden <major@redhat.com> (cherry picked from commit cced1a3) * [Docs] Document the resource module builder (#62222) (cherry picked from commit b17581a) * Fix link syntax and a typo in dev collections doc (#62650) (cherry picked from commit 2969614) * hcloud_volume: clarify volume size units (#62771) (cherry picked from commit 190b8fc) * ovirt_host update force doc (#62491) (cherry picked from commit 3b2b418) * update example document for zabbix_action module (#62667) (cherry picked from commit 3299f29)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
According to the API documentation the volume size is given and returned in GB. Mention the size in the input parameter and fix the unit in the return parameter.
ISSUE TYPE
COMPONENT NAME
hcloud_volume