Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_vm add reboot state #62785

Merged
merged 4 commits into from
Sep 30, 2019
Merged

ovirt_vm add reboot state #62785

merged 4 commits into from
Sep 30, 2019

Conversation

mnecas
Copy link
Contributor

@mnecas mnecas commented Sep 24, 2019

SUMMARY

ovirt_vm add reboot state

Fixes #62775

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ovirt

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 24, 2019

cc @machacekondra @mwperina
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 24, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vm.py:2319:161: E501: line too long (164 > 160 characters)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 24, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 24, 2019
machacekondra
machacekondra approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@machacekondra machacekondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

mwperina
mwperina approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vm.py:2320:68: bad-whitespace: Exactly one space required after comma             'absent', 'next_run', 'present', 'registered', 'running','stopped', 'suspended', 'exported', 'reboot'                                                                     ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_vm.py:2320:69: E231: missing whitespace after ','

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 24, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 25, 2019
mwperina
mwperina approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 30, 2019
@ansibot ansibot added the shipit This PR is ready to be merged by Core label Sep 30, 2019
@ansibot ansibot merged commit 9aff5f6 into ansible:devel Sep 30, 2019
@ansible ansible locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machacekondra machacekondra machacekondra approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'restart' state/parameter to the ovirt_vm module
4 participants
@mnecas @ansibot @machacekondra @mwperina