Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword async intro for clarity #62926

Closed
wants to merge 1 commit into from
Closed

Reword async intro for clarity #62926

wants to merge 1 commit into from

Conversation

brc
Copy link
Contributor

@brc brc commented Sep 27, 2019

SUMMARY

As an intelligent reader, I had to read and re-read (and re-read) the first
sentence of this document, over and over again, yet it still didn't make sense.
This isn't my fault as a reader because the sentence was written so poorly.
English speakers will find this flow easier to understand now.

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

COMPONENT NAME

async

ADDITIONAL INFORMATION

n/a

As an intelligent reader, I had to read and re-read (and re-read) the first
sentence of this document, over and over again, yet it still didn't make sense.
This isn't my fault as a reader because the sentence was written so poorly.
English speakers will find this flow easier to understand now.

- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Sep 28, 2019

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 28, 2019
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Oct 1, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Oct 1, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 9, 2019
@acozine
Copy link
Contributor

acozine commented Oct 29, 2019

Thanks for working on the intro to this page @invsblduck. Your changes can't be merged cleanly now, since we merged #63056. But I've cherry-picked your commit onto my next set of User Guide changes, so you should see most of your suggestions adopted soon.

@acozine acozine closed this Oct 29, 2019
@brc
Copy link
Contributor Author

brc commented Oct 30, 2019

@acozine No worries! Doesn't matter to me whether you use my text verbatim or not. But worth mentioning: The hangup I encountered as a new reader was misinterpretation of the word "block" in the first sentence--my brain was thinking "code block," and I just couldn't get past wondering what the author was really intending to convey.

As the old programmer that I am, blocking vs. non-blocking becomes embarrassingly obvious (especially for a page about async ;-)), but the first sentence just needs a more graceful context/intro at least.

Thanks!

@ansible ansible locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants