Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios_bgp : Fix for bug #59083 #63055

Merged
merged 2 commits into from Oct 4, 2019
Merged

ios_bgp : Fix for bug #59083 #63055

merged 2 commits into from Oct 4, 2019

Conversation

GomathiselviS
Copy link
Contributor

SUMMARY
Added fix to handle idempotentency issue when using networks on classful boundaries

Fixes #59083

ISSUE TYPE
Bugfix Pull Request

COMPONENT NAME
lib/ansible/module_utils/network/ios/providers/cli/config/bgp/process.py

@ansibot
Copy link
Contributor

ansibot commented Oct 2, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Oct 2, 2019
@goneri goneri added the ci_verified Changes made in this PR are causing tests to fail. label Oct 2, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 2, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/providers/cli/config/bgp/process.py:92:63: bad-whitespace: Exactly one space required after comma             if entry['masklen'] and entry['masklen'] not in (24,16,8):                                                                ^
lib/ansible/module_utils/network/ios/providers/cli/config/bgp/process.py:92:66: bad-whitespace: Exactly one space required after comma             if entry['masklen'] and entry['masklen'] not in (24,16,8):                                                                   ^

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/providers/cli/config/bgp/process.py:92:64: E231: missing whitespace after ','
lib/ansible/module_utils/network/ios/providers/cli/config/bgp/process.py:92:67: E231: missing whitespace after ','

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/ios_bgp/tests/cli/basic.yaml:416:1: empty-lines: too many blank lines (4 > 3)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Oct 2, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 2, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 2, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 2, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@GomathiselviS
Copy link
Contributor Author

recheck

@pabelanger pabelanger mentioned this pull request Oct 2, 2019
Closed
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 2, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 2, 2019
NilashishC
NilashishC approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@NilashishC NilashishC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me +1

@Qalthos Qalthos merged commit 7ac4756 into ansible:devel Oct 4, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@NilashishC NilashishC NilashishC approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cisco Cisco technologies has_issue ios Cisco IOS community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ios_bgp - Not idempotent when using networks on classful boundaries
5 participants
@GomathiselviS @ansibot @Qalthos @NilashishC @goneri