Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bry properties #63213

Closed
wants to merge 8 commits into from
Closed

Bry properties #63213

wants to merge 8 commits into from

Conversation

brian-jarvis
Copy link

SUMMARY

Add setting properties to the systemd module by executing the systemctl set-property command.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

systemd

ADDITIONAL INFORMATION

Specify systemd properties as dictionary items. Output from module is updated after any changes to reflect the change in the results.

  • name: set cpushare and memory on sshd.service
    systemd:
    name: sshd.service
    properties:
    CPUShares: 750
    MemoryLimit: 750M

@ansibot
Copy link
Contributor

ansibot commented Oct 7, 2019

@brian-jarvis this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 7, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/systemd.py:0:0: module-invalid-version-added-number: version_added for new option (properties) is not a valid version number: '2.9x'

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/system/systemd.py:338:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/system/systemd.py:346:26: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:346:33: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:346:40: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:346:47: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:350:33: E226: missing whitespace around arithmetic operator

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels Oct 7, 2019
@sivel
Copy link
Member

sivel commented Oct 7, 2019

We decided somewhat recently that we did not want to accept such a feature: #54302

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_triage Needs a first human triage before being processed. labels Oct 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 7, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/systemd.py:0:0: option-incorrect-version-added: version_added for new option (properties) should be '2.10'. Currently StrictVersion ('0.0')

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/system/systemd.py:337:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/system/systemd.py:345:26: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:345:33: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:345:40: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:345:47: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:349:33: E226: missing whitespace around arithmetic operator

click here for bot help

@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 7, 2019

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/system/systemd.py:338:1: E302: expected 2 blank lines, found 1
lib/ansible/modules/system/systemd.py:346:26: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:346:33: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:346:40: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:346:47: E231: missing whitespace after ':'
lib/ansible/modules/system/systemd.py:350:33: E226: missing whitespace around arithmetic operator

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Oct 7, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 8, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 16, 2019
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 16, 2020
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md support:community This issue/PR relates to code supported by the Ansible community. labels May 27, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 6, 2020
@jborean93
Copy link
Contributor

Closing as per #63213 (comment)

@jborean93 jborean93 closed this Jan 26, 2022
@ansible ansible locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 collection Related to Ansible Collections work feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. pre_azp This PR was last tested before migration to Azure Pipelines. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brian-jarvis @ansibot @sivel @jborean93