Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use multiprocessing fork start method #63581

Merged
merged 4 commits into from
Oct 16, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Oct 16, 2019

SUMMARY

Explicitly set the mutliprocessing start method to fork to avoid issues with the default on macOS now being spawn.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/executor/process/worker.py
lib/ansible/executor/task_queue_manager.py

ADDITIONAL INFORMATION

@sivel sivel requested a review from nitzmahone October 16, 2019 17:27
@sivel
Copy link
Member Author

sivel commented Oct 16, 2019

The python PR that necessitated this change: python/cpython#13603

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 16, 2019
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified this prevents Python 3.8.0 from stack tracing on macOS.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 16, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 16, 2019
@sivel
Copy link
Member Author

sivel commented Oct 16, 2019

Unrelated test failure.

@sivel sivel merged commit 82ee341 into ansible:devel Oct 16, 2019
sivel added a commit to sivel/ansible that referenced this pull request Oct 16, 2019
…e#63581)

* Explicitly use multiprocessing fork start method

* Remove unused import

* Remove unused import

* Fallback to just multiprocessing on py2
(cherry picked from commit 82ee341)

Co-authored-by: Matt Martz <matt@sivel.net>
nitzmahone pushed a commit that referenced this pull request Nov 12, 2019
#63591)

* Explicitly use multiprocessing fork start method

* Remove unused import

* Remove unused import

* Fallback to just multiprocessing on py2
(cherry picked from commit 82ee341)

Co-authored-by: Matt Martz <matt@sivel.net>
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants