-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly use multiprocessing fork start method #63581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python PR that necessitated this change: python/cpython#13603 |
nitzmahone
approved these changes
Oct 16, 2019
samdoran
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and verified this prevents Python 3.8.0 from stack tracing on macOS.
Unrelated test failure. |
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Oct 16, 2019
…e#63581) * Explicitly use multiprocessing fork start method * Remove unused import * Remove unused import * Fallback to just multiprocessing on py2 (cherry picked from commit 82ee341) Co-authored-by: Matt Martz <matt@sivel.net>
nitzmahone
pushed a commit
that referenced
this pull request
Nov 12, 2019
#63591) * Explicitly use multiprocessing fork start method * Remove unused import * Remove unused import * Fallback to just multiprocessing on py2 (cherry picked from commit 82ee341) Co-authored-by: Matt Martz <matt@sivel.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.10
This issue/PR affects Ansible v2.10
bug
This issue/PR relates to a bug.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Explicitly set the
mutliprocessing
start method tofork
to avoid issues with the default on macOS now beingspawn
.ISSUE TYPE
COMPONENT NAME
lib/ansible/executor/process/worker.py
lib/ansible/executor/task_queue_manager.py
ADDITIONAL INFORMATION