Add ansible cli options --ask-vault-password and --vault-pass-file #63782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
samdoran
removed
the
needs_triage
samdoran
suggested changes
Oct 22, 2019
There was a problem hiding this comment.
Rather than adding additional calls to add_argument(), just add additional parameters to the existing add_argument() calls.
Also, please create a changelog fragment and add integration tests to test/integration/targets/vault. See this fragment as an example.
| @@ -365,5 +365,9 @@ def add_vault_options(parser): | |||
| base_group = parser.add_mutually_exclusive_group() | |||
| base_group.add_argument('--ask-vault-pass', default=C.DEFAULT_ASK_VAULT_PASS, dest='ask_vault_pass', action='store_true', | |||
There was a problem hiding this comment.
Suggested change
| base_group.add_argument('--ask-vault-pass', default=C.DEFAULT_ASK_VAULT_PASS, dest='ask_vault_pass', action='store_true', | |
| base_group.add_argument('--ask-vault-pass', '--ask-vault-password', default=C.DEFAULT_ASK_VAULT_PASS, dest='ask_vault_pass', action='store_true', |
ansibot
added
support:community
bcoca
approved these changes
Oct 23, 2019
samdoran
suggested changes
Oct 23, 2019
ansibot
added
the
stale_ci
|
@ivog74 Are you still working on this? Thanks. |
|
@ivog74 this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibot
added
merge_commit
added 6 commits
December 18, 2019 15:05
…-file' to the existing calls to add_argument
…rd and --vault-password-file by default
…vault-password and --vault-pass-file
ansibot
removed
the
merge_commit
ansibot
removed
the
needs_rebase
samdoran
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The ansible-playbook command provides 2 options to specify a vault password:
--ask-vault-pass
--vault-password-file
One option use 'pass', the other uses 'password'. I propose to use either pass or password for both option. For now I added the following options:
-- ask-vault-password
--vault-pass-file
ISSUE TYPE
COMPONENT NAME
ansible cli
ADDITIONAL INFORMATION
before:
after:
or