Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ovirt host network dict correct #64437

Merged
merged 2 commits into from Nov 5, 2019
Merged

Ovirt host network dict correct #64437

merged 2 commits into from Nov 5, 2019

Conversation

mnecas
Copy link
Contributor

@mnecas mnecas commented Nov 5, 2019

SUMMARY

ovirt_host_network:

  • correct comparing of two dicts
  • correct when user uses 4th mode so it would not return status as changed

Fixes #62909

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Nov 5, 2019

cc @machacekondra @mwperina
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Nov 5, 2019
mwperina
mwperina approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Nov 5, 2019
@ansibot ansibot merged commit d9f5be8 into ansible:devel Nov 5, 2019
mnecas added a commit to mnecas/ansible that referenced this pull request Nov 5, 2019
@mnecas
Ovirt host network dict correct (ansible#64437)
9466877 
* ovirt_host_network: correct comparing of two dicts

* update mode_number for 4th option
@mnecas mnecas mentioned this pull request Nov 5, 2019
Merged
mattclay pushed a commit that referenced this pull request Nov 12, 2019
@mnecas @mattclay
Ovirt host network dict correct backport (#64444)
870294b 
* Ovirt host network dict correct (#64437)

* ovirt_host_network: correct comparing of two dicts

* update mode_number for 4th option

* add changelog

* add changelog
@ansible ansible locked and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ovirt_host_network throws typerror '<' not supported between instances of 'dict' and 'dict'
3 participants
@mnecas @ansibot @mwperina