dnf: don't return fail_json['msg'] as list #65302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
|
I was told by @felixfontein on irc that this bugfix needs a changelog entry file. |
|
needs changelog fragment, but otherwise it's good |
|
shipit |
ansibot
removed
the
needs_triage
|
@ianw could you merge @ssbarnea's PR on your branch, or add a (similar) changelog fragment yourself? (If you merge the PR: make sure to either choose "Rebase and merge" or "Squash and merge" (via the arrow next to the big green merge button); the default merge will create a merge commit, which will cause ansibot to scream at you :) ) |
Although it's not enforced that fail_json['msg'] should be a string [1], I think it is pretty strongly implied. In this case the failure_response['msg'] is sent through as the fail_json['msg'], and the trailing commas here turn it into a tuple. It's not clear if this is a typo or intended, but it does cause problems for callbacks that expect this as a string (e.g. [2]). Since there seems no point to having these values as a tuple, remove the trailing commas so they return a string as per everywhere else. [1] https://github.com/ansible/ansible/blob/4c589661c2add45023f2bff9203e0c4e11efe5f6/lib/ansible/module_utils/basic.py#L2078 [2] https://review.opendev.org/#/c/696081
ianw
force-pushed
the
dnf-failing-comma
branch
from
f29baff
to
cbe43cb
Compare
@felixfontein @ssbarnea done with the latest changeset, thanks |
ansibot
added
support:community
|
rebuild_merge |
ansibot
added
shipit
|
Awesome! Who wants to create a backport PR? |
ssbarnea
pushed a commit
to ssbarnea/ansible
that referenced
this pull request
Dec 5, 2019
Although it's not enforced that fail_json['msg'] should be a string [1], I think it is pretty strongly implied. In this case the failure_response['msg'] is sent through as the fail_json['msg'], and the trailing commas here turn it into a tuple. It's not clear if this is a typo or intended, but it does cause problems for callbacks that expect this as a string (e.g. [2]). Since there seems no point to having these values as a tuple, remove the trailing commas so they return a string as per everywhere else. [1] https://github.com/ansible/ansible/blob/4c589661c2add45023f2bff9203e0c4e11efe5f6/lib/ansible/module_utils/basic.py#L2078 [2] https://review.opendev.org/#/c/696081 (cherry picked from commit fc54ae9)
ssbarnea
pushed a commit
to ssbarnea/ansible
that referenced
this pull request
Dec 5, 2019
Although it's not enforced that fail_json['msg'] should be a string [1], I think it is pretty strongly implied. In this case the failure_response['msg'] is sent through as the fail_json['msg'], and the trailing commas here turn it into a tuple. It's not clear if this is a typo or intended, but it does cause problems for callbacks that expect this as a string (e.g. [2]). Since there seems no point to having these values as a tuple, remove the trailing commas so they return a string as per everywhere else. [1] https://github.com/ansible/ansible/blob/4c589661c2add45023f2bff9203e0c4e11efe5f6/lib/ansible/module_utils/basic.py#L2078 [2] https://review.opendev.org/#/c/696081 (cherry picked from commit fc54ae9)
anshulbehl
pushed a commit
to anshulbehl/ansible
that referenced
this pull request
Dec 10, 2019
Although it's not enforced that fail_json['msg'] should be a string [1], I think it is pretty strongly implied. In this case the failure_response['msg'] is sent through as the fail_json['msg'], and the trailing commas here turn it into a tuple. It's not clear if this is a typo or intended, but it does cause problems for callbacks that expect this as a string (e.g. [2]). Since there seems no point to having these values as a tuple, remove the trailing commas so they return a string as per everywhere else. [1] https://github.com/ansible/ansible/blob/4c589661c2add45023f2bff9203e0c4e11efe5f6/lib/ansible/module_utils/basic.py#L2078 [2] https://review.opendev.org/#/c/696081
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Although it's not enforced that fail_json['msg'] should be a string
[1], I think it is pretty strongly implied.
In this case the failure_response['msg'] is sent through as the
fail_json['msg'], and the trailing commas here turn it into a tuple.
It's not clear if this is a typo or intended, but it does cause
problems for callbacks that expect this as a string (e.g. [2]).
Since there seems no point to having these values as a tuple, remove
the trailing commas so they return a string as per everywhere else.
[1]
ansible/lib/ansible/module_utils/basic.py
Line 2078 in 4c58966
[2] https://review.opendev.org/#/c/696081
ISSUE TYPE
COMPONENT NAME
dnf