Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'nic_gce_struct' to gcp_compute_template. #65500

Closed
wants to merge 1 commit into from
Closed

Added 'nic_gce_struct' to gcp_compute_template. #65500

wants to merge 1 commit into from
+4 −0

Conversation

sbulage
Copy link
Contributor

@sbulage sbulage commented Dec 4, 2019

Signed-off-by: Satyajit Bulage sbulage@redhat.com

SUMMARY

Fixed #40219 by retrieving nic_gce_struct from params.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gce_instance_template

@sbulage
Added 'nic_gce_struct' to gcp_compute_template.
3bbe653 
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Dec 4, 2019

cc @GwenaelPellenArkeup @erjohnso @rambleraptor
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Dec 4, 2019
@sbulage
Copy link
Contributor Author

sbulage commented Dec 4, 2019

FYI @Akasurde

Akasurde
Akasurde approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 4, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 12, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 26, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@Akasurde
Copy link
Member

Akasurde commented Jul 2, 2020

@sbulage Thank you very much for your interest in Ansible. This plugin/module is no longer maintained in this repository and has been migrated to community.general. Could you please migrate this PR to the above-mentioned repo?

If you have further questions please stop by IRC or the mailing list:

Thanks,

needs_info

@Akasurde Akasurde closed this Jul 2, 2020
@ansible ansible locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud collection:community.general collection Related to Ansible Collections work gce module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nic_gce_struct is not processed in gce_instance_template.py
3 participants
@sbulage @ansibot @Akasurde