Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct indentation of tasks definition in vars_files example #66408

Closed
wants to merge 1 commit into from
Closed

correct indentation of tasks definition in vars_files example #66408

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Jan 13, 2020

SUMMARY
ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

@evgeni
correct indentation of tasks definition in vars_files example
4493bf0 
##### SUMMARY
<!--- Your description here -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Jan 13, 2020

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 13, 2020
@bcoca
Copy link
Member

bcoca commented Jan 13, 2020

The indentation is already correct, lists can start at same level as the token that includes them

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 13, 2020
jamescassell
jamescassell suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine as is.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 14, 2020
@samccann
Copy link
Contributor

Thanks @evgeni for looking into the Ansible documentation! Closing this PR based on the review feedback above.

@samccann samccann closed this Jan 14, 2020
@samccann samccann mentioned this pull request Jan 14, 2020
Closed
@ansible ansible locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamescassell jamescassell jamescassell requested changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@evgeni @ansibot @bcoca @samccann @jamescassell