Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zabbix: add integration test for zabbix_user module #66418

Merged
merged 3 commits into from Feb 15, 2020
Merged

Zabbix: add integration test for zabbix_user module #66418

merged 3 commits into from Feb 15, 2020

Conversation

sky-joker
Copy link
Contributor

SUMMARY

integration test for zabbix_user module

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

zabbix_user

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jan 13, 2020

cc @D3DeFi @rubentsirunyan
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. monitoring Monitoring category needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. zabbix Zabbix community labels Jan 13, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 13, 2020
@sky-joker sky-joker closed this Jan 13, 2020
@sky-joker sky-joker reopened this Jan 13, 2020
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 13, 2020
D3DeFi
D3DeFi approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for these tests!

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jan 14, 2020
@gundalow gundalow merged commit d044390 into ansible:devel Feb 15, 2020
@mattclay
Copy link
Member

The tests are failing and have been disabled in #67487.

@D3DeFi
Copy link
Contributor

D3DeFi commented Feb 18, 2020

Hello, I would argue that we don't need tests on AIX at all, so it is ok for them to be skipped, but disabling them as a whole was unecessary tho. Is there something else we should do before re-enabling them?

@mattclay
Copy link
Member

@D3DeFi The tests have already been disabled on AIX. The test failures on Ubuntu will need to be fixed before the tests can be re-enabled.

@sky-joker
Copy link
Contributor Author

Hello all, This PR can solve this problem.

@sky-joker sky-joker deleted the zabbix_user_integration_test branch February 19, 2020 08:12
@D3DeFi
Copy link
Contributor

D3DeFi commented Feb 19, 2020

@D3DeFi The tests have already been disabled on AIX. The test failures on Ubuntu will need to be fixed before the tests can be re-enabled.

MB, somehow failed to see that it related to the ubuntu as well, thanks

@ansible ansible locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@D3DeFi D3DeFi D3DeFi approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. monitoring Monitoring category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. zabbix Zabbix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sky-joker @ansibot @mattclay @D3DeFi @gundalow