zabbix_template - enable new update rule to delete missing linked templates

[rockaut]

SUMMARY

New update rule is available from 4.0.16 and 4.4.4 up. Add check for version and enable new update rule.

fixes #66720

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

zabbix_template

ADDITIONAL INFORMATION

Using new update rule set to true, linked templates getting unlinked if removed from xml/json files.

[ansibot]

cc @D3DeFi @logan2211 @rubentsirunyan @sky-joker @sookido
click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/modules/monitoring/zabbix/zabbix_template.py:608:15: bad-whitespace: No space allowed after bracket             if ( LooseVersion(api_version).version[:3] >= LooseVersion('4.0.16').version ) or \                ^
lib/ansible/modules/monitoring/zabbix/zabbix_template.py:608:89: bad-whitespace: No space allowed before bracket             if ( LooseVersion(api_version).version[:3] >= LooseVersion('4.0.16').version ) or \                                                                                          ^
lib/ansible/modules/monitoring/zabbix/zabbix_template.py:609:16: bad-whitespace: No space allowed after bracket                 ( LooseVersion(api_version).version[:3] >= LooseVersion('4.4.4').version ):                 ^
lib/ansible/modules/monitoring/zabbix/zabbix_template.py:609:89: bad-whitespace: No space allowed before bracket                 ( LooseVersion(api_version).version[:3] >= LooseVersion('4.4.4').version ):                                                                                          ^

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

lib/ansible/modules/monitoring/zabbix/zabbix_template.py:608:17: E201: whitespace after '('
lib/ansible/modules/monitoring/zabbix/zabbix_template.py:608:89: E202: whitespace before ')'
lib/ansible/modules/monitoring/zabbix/zabbix_template.py:609:17: E125: continuation line with same indent as next logical line
lib/ansible/modules/monitoring/zabbix/zabbix_template.py:609:18: E201: whitespace after '('
lib/ansible/modules/monitoring/zabbix/zabbix_template.py:609:89: E202: whitespace before ')'
lib/ansible/modules/monitoring/zabbix/zabbix_template.py:610:16: E111: indentation is not a multiple of four

click here for bot help

[rockaut]

Is there a way to rerun the shippable tests?

[Akasurde]

@D3DeFi @sky-joker Could you please review this?

[sky-joker]

Thank you @rockaut for reporting and patch the issues!

Is there a way to rerun the shippable tests?

You need to close and open this PR.

[rockaut]

I updated the version checks. It's not pretty or efficient but also not too shabby imo.
I splitted the 4.0 and 4.4 version check on intention for readability to not get a long if-and-or clause.

Can someone check it against a 4.2 branch. I don't have one at hand.

[D3DeFi]

I updated the version checks. It's not pretty or efficient but also not too shabby imo.
I splitted the 4.0 and 4.4 version check on intention for readability to not get a long if-and-or clause.

Can someone check it against a 4.2 branch. I don't have one at hand.

works for me, thanks

shipit

[rockaut]

Why is this one check (#60) always "unstable"? I don't get it. It says something about mysql ...

{
"changed": false,
"msg": "Unable to start service mysql: Job for mysql.service failed because the control process exited with error code.\nSee \"systemctl status mysql.service\" and \"journalctl -xe\" for details.\n"
}

[D3DeFi]

Why is this one check (#60) always "unstable"? I don't get it. It says something about mysql ...

{
"changed": false,
"msg": "Unable to start service mysql: Job for mysql.service failed because the control process exited with error code.\nSee \"systemctl status mysql.service\" and \"journalctl -xe\" for details.\n"
}

If I am not mistaken, integration testing workflow should go like this (note that every integration role has its own generated play):

1. roles not important for us right now
2. test/integration/targets/setup_mysql_db (as prereq for roles below)
3. test/integration/targets/mysql_*
4. test/integration/targets/setup_mysql_db/handlers/main.yml (cleanup after setup_mysql_db role)
5. roles not important for us right now
6. test/integration/targets/setup_mysql_db (as prereq for roles below)
7. test/integration/targets/setup_zabbix
8. test/integration/targets/zabbix_*

Problem probably resides at the step 4. I would start searching there as there may be something that should be cleaned up after mysql daemon, but currently is not, preventing second installation of mysql on the same container from starting correctly.

Shame on me as I've met this error more than once, but never really tried to dive deeper into it as close & reopen of PR was quicker atm for me, but shortsighted. Lets see If I can come up with something for it today and open a PR for mysql maintainers.

[rockaut]

Thank you @D3DeFi ... ping me if I have something to do.

[D3DeFi]

@rockaut please try to close & reopen this PR until CI build passes. No need for this PR to wait for fixes meant for setup_mysql_db.

[rockaut]

temporary close for pipeline fixes

[rockaut]

reopen for pipeline build

[D3DeFi]

shipit

[sky-joker]

Looks good to me :)
Thank you @rockaut!

shipit