Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Remove openstack bits #66790

Closed
wants to merge 1 commit into from
Closed

WIP: Remove openstack bits #66790

wants to merge 1 commit into from

Conversation

sshnaidm
Copy link
Contributor

remove all openstack files after it's moved to collection openstack.cloud

hold-on

@ansibot
Copy link
Contributor

ansibot commented Jan 26, 2020

@sshnaidm This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.10 This issue/PR affects Ansible v2.10 needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. labels Jan 26, 2020
@opendev-zuul
Copy link

opendev-zuul bot commented Jan 26, 2020

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

gundalow
gundalow requested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as requires changes as we can't merge this till Collection docs build work is done.

docs/docsite/rst/dev_guide/platforms/openstack_guidelines.rst
@@ -1,60 +0,0 @@
.. _OpenStack_module_development:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acozine @abadger Should dev_guide documentation guides stay in ansible/ansble?
@sshnaidm Does this documentation exist elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gundalow not in openstack repo, but as I see it's mostly incorrect atm. So anyways we'll need to write a new one. I'll submit a patch with this file and we'll start to review it. In the current state it's totally outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gundalow submitted in https://review.opendev.org/#/c/704558/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you.

@willtome willtome mentioned this pull request Jan 28, 2020
Closed
@gundalow
Copy link
Contributor

gundalow commented Mar 5, 2020

So the world has moved on since we originally talked about this.

This will happen automatically when the migrate.py script gets run on Monday

@gundalow gundalow closed this Mar 5, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 6, 2020
@ansible ansible locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow requested changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sshnaidm @ansibot @gundalow @sivel