Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module validation: sanity check mutually_exclusive, required_if, required_xxx ... #66961
Module validation: sanity check mutually_exclusive, required_if, required_xxx ... #66961
Changes from all commits
bff8846
8c51139
e94b019
4f186ca
008f666
14fc847
17884b2
1869ddd
87c84c5
3007417
e7dc40b
e699b8a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to catch
TypeError
here rather thanException
. Though I suppose a custom callable as a type checker could raise something other thanTypeError
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the same
catch
expression asansible/test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py
Lines 1490 to 1497 in 8839b5b
ansible/test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/main.py
Lines 1450 to 1453 in 8839b5b