Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_unzip - LiteralPath fix #66972

Merged
merged 2 commits into from Jan 31, 2020
Merged

win_unzip - LiteralPath fix #66972

merged 2 commits into from Jan 31, 2020

Conversation

jborean93
Copy link
Contributor

SUMMARY

If using a path with square brackets as the source or dest in win_unzip it will fail in a few places. This PR fixes up those issues and making sure we test with those paths by default.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_unzip

@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2020

cc @ShachafGoldstein @if-meaton @jhawkesworth @mattclay @schwartzmx @tremble
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Jan 31, 2020
@jborean93 jborean93 merged commit 2a9ec89 into ansible:devel Jan 31, 2020
@jborean93 jborean93 deleted the win_unzip-literalpath branch January 31, 2020 03:00
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Feb 3, 2020
@ansible ansible locked and limited conversation to collaborators Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @mkrizek