ansible-galaxy - fix role list bug #67391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
bcoca
approved these changes
Feb 13, 2020
ansibot
added
needs_revision
Properly list roles even when the role name is the same or a substring of the path to the role.
samdoran
force-pushed
the
issue/67365-role-name-in-roles-path
branch
from
4dd736a
to
80dce2a
Compare
s-hertel
approved these changes
Feb 17, 2020
sivel
removed
the
needs_triage
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Feb 20, 2020
Properly list roles even when the role name is the same or a substring of the path to the role.. (cherry picked from commit c64202a) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Mar 2, 2020
Properly list roles even when the role name is the same or a substring of the path to the role. (cherry picked from commit c64202a)
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Mar 2, 2020
Properly list roles even when the role name is the same or a substring of the path to the role. (cherry picked from commit c64202a)
mattclay
pushed a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Properly list roles even when the role name is the same or a substring of the path to the role.
When the role name is a subset of the role path, the full path to the role would be improperly constructed. This resulted in a failure to find the
meta/main.ymlfile for the role, resulting in the role not being listed.Fixes #67365
ISSUE TYPE
COMPONENT NAME
lib/ansible/galaxy/role.py