better error for "ansible-galaxy collection verify" if there's no MANIFEST.json #67498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as been deleted from the installed collection or if the collection hasn't been installed via normal means
s-hertel
changed the title
ansibot
added
affects_2.10
s-hertel
commented
Feb 17, 2020
ansibot
added
needs_revision
If there's something wrong with the local collection's version it will fail before the remote collection is sought
ansibot
added
core_review
samdoran
removed
the
needs_triage
samdoran
reviewed
Feb 27, 2020
ansibot
added
the
stale_ci
Mock the new isfile call where needed
ansibot
added
needs_revision
samdoran
approved these changes
Feb 28, 2020
mkrizek
reviewed
Feb 28, 2020
Co-Authored-By: Martin Krizek <martin.krizek@gmail.com>
ansibot
added
the
stale_ci
ansibot
added
core_review
ansibot
added
the
stale_ci
|
Related? #67490 |
|
@geerlingguy Yes. I commented on that issue with this PR. #68925 is the main fix though. |
ansibot
added
needs_revision
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The MANIFEST.json may have been deleted from the installed collection or the collection may not have been installed via normal means
The error message is misleading right now (e.g.
openstack.cloud has the version '*' but is being compared to '1.0.0') since an installed collection could never have an undefined version. Built collections do not have a galaxy.yml for finding the version and only built collections should be install-able for verification against a server.ISSUE TYPE