Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New attribute "submodules" to select which sub-module to update. #6752

Closed
wants to merge 4 commits into from

Conversation

eroldan
Copy link
Contributor

@eroldan eroldan commented Mar 29, 2014

Replaces "recursive" functionality.
Changes error handling when doing submodule operations

@mpdehaan
Copy link
Contributor

This behavior should probably be tweaked because we don't like giving meaningful behavior to empty strings or contrasting None with "", which both have a "truthiness" in Python as False.

+            - Which sub-modules will be updated. Empty string skips all.
+              If this argument is not supplied all sub-modules will be
+              updated. 

Can we change this to "none" skips all submodules?

(Be sure to do a case insensitive match also)

Thanks!

@mpdehaan
Copy link
Contributor

(Note that will have to be applied in 1.6 timeframe as the recursive module is new in 1.6, and otherwise can't be removed)

@mpdehaan mpdehaan added the P3 label Mar 29, 2014
@eroldan
Copy link
Contributor Author

eroldan commented Mar 30, 2014

Your recommendations were done. Thanks!

Replaces "recursive" functionality.
Changes error handling when doing submodule operations
replaced for with oneliners
fix bug when using bare=yes
@leth
Copy link
Contributor

leth commented Apr 9, 2014

FYI: the recursive flag is currently broken -- setting to to 'no' does not prevent all sending of "--recursive" flags to git

@eroldan
Copy link
Contributor Author

eroldan commented May 7, 2014

Bummer. Ansible 1.6 is released making the 'recursive' parameter written in stone :(
Maybe I can adapt the "submodule" parameter to coexist with recursive, but I'm not very interested right now.
As others stated, the "recursive" flag is broken in 1.6 release, this fix seems ok https://github.com/ansible/ansible/pull/7033/commits

@jimi-c
Copy link
Member

jimi-c commented May 9, 2014

@eroldan based on the above, I'm going to go ahead and close this. If you do have further ideas to improve the functionality of the git module please let us know. Thanks!

@jimi-c jimi-c closed this May 9, 2014
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants