Fix inline vaults for plugins in ensure_type (#67492) #67741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix implicit string - only looked right because of the vault __repr__ * Add tests for strings and implicit strings (cherry picked from commit 8eb00dd)
ansibot
added
affects_2.9
mattclay
added
the
backport_verified
mattclay
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport of #67492
Connection plugins have been able to use inline vaults due to using vars (rather than direct), because it was fixed in _loop_entries. This fixes it universally for plugins in ensure_type for string options.
(cherry picked from commit 8eb00dd)
ISSUE TYPE