Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subversion module - provide password securely when possible or warn #67829

Merged
merged 5 commits into from Apr 13, 2020
Merged

subversion module - provide password securely when possible or warn #67829

merged 5 commits into from Apr 13, 2020

Conversation

s-hertel
Copy link
Contributor

SUMMARY

Use svn command line option --password-from-stdin when possible, and provide a warning otherwise

Fixes #67797

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

subversion module

@s-hertel
subversion module - provide password securely with svn command line o…
b36f689 
…ption --password-from-stdin when possible, and provide a warning otherwise
@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2020

cc @dsummersl
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 27, 2020
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 2, 2020
samdoran
samdoran reviewed Mar 2, 2020
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks great. Is there any way we could add tests to see if a warning is displayed based on the svn version on the target system? It looks like our CentOS 7 image has svn 1.7.14 and CentOS 8 has 1.10.2, so at least for those two we would see both scenarios.

@s-hertel @samdoran
Update lib/ansible/modules/source_control/subversion.py
001892f 
Co-Authored-By: Sam Doran <sdoran@redhat.com>
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 12, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 8, 2020
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 9, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 9, 2020
@bcoca bcoca merged commit d91658e into ansible:devel Apr 13, 2020
s-hertel added a commit to s-hertel/ansible that referenced this pull request Apr 13, 2020
@s-hertel
subversion module - provide password securely when possible or warn (a…
641ff41 
…nsible#67829)

* subversion module - provide password securely with svn command line option --password-from-stdin when possible, and provide a warning otherwise.
* Update lib/ansible/modules/source_control/subversion.py.
* Add a test.

Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit d91658e)
s-hertel added a commit to s-hertel/ansible that referenced this pull request Apr 13, 2020
@s-hertel
subversion module - provide password securely when possible or warn (a…
3771218 
…nsible#67829)

* subversion module - provide password securely with svn command line option --password-from-stdin when possible, and provide a warning otherwise.
* Update lib/ansible/modules/source_control/subversion.py.
* Add a test.

Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit d91658e)
s-hertel added a commit to s-hertel/ansible that referenced this pull request Apr 13, 2020
@s-hertel
subversion module - provide password securely when possible or warn (a…
a81aa05 
…nsible#67829)

* subversion module - provide password securely with svn command line option --password-from-stdin when possible, and provide a warning otherwise.
* Update lib/ansible/modules/source_control/subversion.py.
* Add a test.

Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit d91658e)
This was referenced Apr 13, 2020
Merged
Merged
Merged
mattclay pushed a commit that referenced this pull request Apr 15, 2020
@s-hertel @mattclay
subversion module - provide password securely when possible or warn (#…
c6c4fbf 
…67829)

* subversion module - provide password securely with svn command line option --password-from-stdin when possible, and provide a warning otherwise.
* Update lib/ansible/modules/source_control/subversion.py.
* Add a test.

Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit d91658e)
mattclay pushed a commit that referenced this pull request Apr 15, 2020
@s-hertel @mattclay
subversion module - provide password securely when possible or warn (#…
6c74a29 
…67829)

* subversion module - provide password securely with svn command line option --password-from-stdin when possible, and provide a warning otherwise.
* Update lib/ansible/modules/source_control/subversion.py.
* Add a test.

Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit d91658e)
mattclay pushed a commit that referenced this pull request Apr 15, 2020
@s-hertel
[2.7] CVE-2020-1739 - provide password securely for subversion module…
1a89d4f 
… or warn (#68913)

* subversion module - provide password securely when possible or warn (#67829)

* subversion module - provide password securely with svn command line option --password-from-stdin when possible, and provide a warning otherwise.
* Update lib/ansible/modules/source_control/subversion.py.
* Add a test.

Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit d91658e)

* Create the OUTPUT_DIR and make sure it is removed at the end

* fix sanity test
@ansible ansible locked and limited conversation to collaborators May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran left review comments

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command used in subversion module is problematic
5 participants
@s-hertel @ansibot @samdoran @mattclay @bcoca