Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.8] openssl_* modules: prevent crash on fingerprint determination in FIPS mode (#67515) #67971

Merged
merged 1 commit into from Mar 4, 2020
Merged

[stable-2.8] openssl_* modules: prevent crash on fingerprint determination in FIPS mode (#67515) #67971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/67515-openssl-fingerprint-fips.yml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- "openssl_* modules - prevent crash on fingerprint determination in FIPS mode (https://github.com/ansible/ansible/issues/67213)."
7 changes: 6 additions & 1 deletion lib/ansible/module_utils/crypto.py
View file
Open in desktop
Expand Up @@ -151,7 +151,12 @@ def get_fingerprint_of_bytes(source):

for algo in algorithms:
f = getattr(hashlib, algo)
h = f(source)
try:
h = f(source)
except ValueError:
# This can happen for hash algorithms not supported in FIPS mode
# (https://github.com/ansible/ansible/issues/67213)
continue
try:
# Certain hash functions have a hexdigest() which expects a length parameter
pubkey_digest = h.hexdigest()
Expand Down