Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove changelog entries related to content that has migrated to collections #68498

Merged
merged 4 commits into from Mar 30, 2020

Conversation

sivel
Copy link
Member

@sivel sivel commented Mar 26, 2020

SUMMARY

Remove changelog entries related to content that has migrated to collections

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

many many many

ADDITIONAL INFORMATION

The changelog entries being removed in this PR relate to content that has migrated to collections.

And more specifically these changelogs only have a 1:1 with where the content was migrated to.

This will be an iterative process, and more changelog fragments will be removed later.

The attached JSON contains the changelog fragment data, and the associated collections. This can be used by the collection owner to pull in their respective changelog data.

changelog.json.txt

@sivel
Copy link
Member Author

sivel commented Mar 26, 2020

bot_skip

@sivel sivel changed the title Remove changelog entries related to content that has migrated to collections [WIP] Remove changelog entries related to content that has migrated to collections Mar 26, 2020
@sivel sivel force-pushed the changelog-reaping-1 branch 2 times, most recently from a8eb890 to dba08fc Compare March 26, 2020 22:32
@sivel sivel closed this Mar 26, 2020
@sivel sivel reopened this Mar 26, 2020
@sivel sivel changed the title [WIP] Remove changelog entries related to content that has migrated to collections Remove changelog entries related to content that has migrated to collections Mar 27, 2020
@sivel
Copy link
Member Author

sivel commented Mar 27, 2020

Ok, I think I have all the logic fixed in my correlation code. Ready for review.

@sivel sivel added core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. labels Mar 27, 2020
@sivel
Copy link
Member Author

sivel commented Mar 27, 2020

These are now all changelogs which do not have a core component relating to the commits associated with the changelog fragment.

@sivel sivel added affects_2.10 This issue/PR affects Ansible v2.10 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 27, 2020
@sivel sivel merged commit 5c7746e into ansible:devel Mar 30, 2020
@sivel
Copy link
Member Author

sivel commented Mar 30, 2020

To get a list of files deleted in this PR from the CLI:

git diff-tree --no-commit-id --name-only -r 5c7746e

Use the attached changelog.json.txt to retrieve the associated changelogs.

@felixfontein
Copy link
Contributor

To make it easier to find all these PRs: #68565 #68567 #68570 #68618

@felixfontein
Copy link
Contributor

@sivel some more fragments which can probably go:

39295-grafana_dashboard.yml
51595-adds-win32_diskdrive-object-to-win_disk_facts.yaml
56033-win_iis_webapplication-add-authentication-options.yml
56966-win_format-allocation-unit-size.yml
58225-win_partition-maximum-partition-size.yml
61227-win_iis_webapplication-apppool-change.yml
61227-win_iis_webapplication-apppool-change.yml
61570-netcli-put-get.yaml
62218-fix-to-entrust-api.yml
63418-docker_node_info-errors.yml
63565-postgresql_user_allow_user_name_with_dots.yml
64559-hcloud-inventory-missing-compose-variables.yaml
64585-mysql_dont_mask_mysql_connect_errors_from_modules.yml
64954_virtualization_podman.yml
65138-Windows_Multidomain_support.yml
netbox-add-cache.yaml
vmware_httpapi_fix.yml
vmware-module_fragments-group.yml
win_become-shared-token.yaml
win_command-encoding.yaml
win_credential-wildcard.yaml
win_disk_facts-Set-output-array-order-by-disk-number.yml
win_disk_facts-Set-output-array-order-by-disk-number.yml
win_format-Idem-not-working-if-file-exist-but-same-fs.yml
win_unzip-paths.yaml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants