Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_url pass incorrect If-Modified-Since header(#67417) (#67419) #68868

Merged
merged 1 commit into from Apr 14, 2020
Merged

get_url pass incorrect If-Modified-Since header(#67417) (#67419) #68868

merged 1 commit into from Apr 14, 2020

Conversation

wangzw
Copy link
Contributor

@wangzw wangzw commented Apr 11, 2020

SUMMARY

Backport #67419 to 2.9

Fix #67417. HTTP header value of If-Modified-Since set by get_url does not follow HTTP protocol.

(cherry picked from commit 1097694)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@wangzw
get_url pass incorrect If-Modified-Since header(#67417) (#67419)
23eb993 
Fix #67417. HTTP header value of `If-Modified-Since` set by `get_url` does not follow HTTP protocol.

(cherry picked from commit 1097694)
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 11, 2020
@mattclay mattclay added backport_verified This PR has been verified as a backport of a merged devel PR. and removed needs_triage Needs a first human triage before being processed. labels Apr 14, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 14, 2020
@mattclay mattclay merged commit f7c63c1 into ansible:stable-2.9 Apr 14, 2020
@ansible ansible locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport_verified This PR has been verified as a backport of a merged devel PR. backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wangzw @mattclay @ansibot