New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to install collections from git repositories #69154
Conversation
This comment has been minimized.
This comment has been minimized.
cc @geerlingguy (since I can't request your review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few docs questions and some behaviour around subdir checks
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
923b9c5
to
eee129e
Compare
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
docs/docsite/rst/shared_snippets/installing_collections_git_repo.txt
Outdated
Show resolved
Hide resolved
- "'namespace_1.collection_1' in installed_collections.stdout" | ||
- "'namespace_2.collection_2' in installed_collections.stdout" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pro tip: you can often get rid of escaping when using YAML blocks:
- "'namespace_1.collection_1' in installed_collections.stdout" | |
- "'namespace_2.collection_2' in installed_collections.stdout" | |
- >- | |
'namespace_1.collection_1' in installed_collections.stdout | |
- >- | |
'namespace_2.collection_2' in installed_collections.stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like the escaping better than the extra lines though in this case.
7c11e07
to
f5ba4c0
Compare
This comment has been minimized.
This comment has been minimized.
That linter error should probably be suppressed because this module runs on the controller AFAIU |
add links for auth options to the docs
…de/collection_using.rst
SUMMARY
Fixes #61680
This adds support for installing collections from git repositories. Use the format git+URI,version (or git@URI,version to use ssh authentication) instead of a collection name. The version is optional and should be a git tree-ish instead of a collection artifact version. The version defaults to HEAD.
A repo can contain multiple or an individual collection. You can append #/path/to/collection/ to the URI to install collections from a particular directory in the repository.
This also adds a new
type
option for collection requirements files (which may be one of 'galaxy', 'file', 'url', or 'git' to override implicitly determining the type from thename
field).ISSUE TYPE
COMPONENT NAME
ansible-galaxy