[yum] Make package removal confirmation strict #69592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: After removing packages, the yum module does a final check to ensure the packages are really installed. The check would include packages that were RPM `Provides:` values of another package. This means that, for example, if a third-party kernel RPM spec had `Provides: kernel` in it, removing the stock kernel would be successful but the check to see if it was really removed would fail and cause Ansible to report a failure. Test Plan: Tested on local CentOS 7 VM with kernel from elrepo which is known to `Provides: kernel`. Tickets: Fixes ansible#69237 Refs ansible#35672 Refs ansible#40723 Signed-off-by: Rick Elrod <rick@elrod.me>
ansibot
added
affects_2.10
|
/cc @maxamillion |
bcoca
removed
the
needs_triage
samdoran
approved these changes
May 26, 2020
|
I totally missed this, sorry. This is great, thanks @relrod! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Change:
After removing packages, the yum module does a final check to ensure the
packages are really uninstalled. The check would include packages that
were RPM
Provides:values of another package.This means that, for example, if a third-party kernel RPM spec had
Provides: kernelin it, removing the stock kernel would be successfulbut the check to see if it was really removed would fail and cause
Ansible to report a failure.
Test Plan:
Tested on local CentOS 7 VM with kernel from elrepo which is known to
Provides: kernel.Tickets:
Fixes #69237
Refs #35672
Refs #40723
Signed-off-by: Rick Elrod rick@elrod.me
ISSUE TYPE
COMPONENT NAME
yum
ADDITIONAL INFORMATION