Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: singular ANSIBLE_COLLECTIONS_PATH #70007

Merged
merged 3 commits into from Jun 11, 2020
Merged

config: singular ANSIBLE_COLLECTIONS_PATH #70007

merged 3 commits into from Jun 11, 2020

Conversation

jamescassell
Copy link
Contributor

SUMMARY

Every other *_PATH setting in ansible is singular, and the traditional
$PATH variable is also singular despite containing a list of
directories. Let's be consistent both internally and with POSIX
tradition.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

config

ADDITIONAL INFORMATION

@jamescassell
config: singular ANSIBLE_COLLECTIONS_PATH
a44689b 
Every other *_PATH setting in ansible is singular, and the traditional
$PATH variable is also singular despite containing a list of
directories.  Let's be consistent both internally and with POSIX
tradition.
@jamescassell jamescassell mentioned this pull request Jun 11, 2020
Closed
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 11, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jun 11, 2020
@abadger abadger merged commit 47d14a3 into ansible:devel Jun 11, 2020
@felixfontein
Copy link
Contributor

@jamescassell @nitzmahone @abadger thanks for creating, reviewing and merging this!

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 11, 2020
@ansible ansible locked and limited conversation to collaborators Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca left review comments

@felixfontein felixfontein felixfontein left review comments

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jamescassell @felixfontein @bcoca @nitzmahone @abadger @samdoran @ansibot